Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Example file #433

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Fixed Example file #433

merged 1 commit into from
Feb 18, 2025

Conversation

gowerc
Copy link
Collaborator

@gowerc gowerc commented Feb 18, 2025

Closes #432

Note that there is no issue here but I updated the example to use subject instead of pt so that it actually works again and also added an additional comment to explain how to manipulate the ggplot2 object

@gowerc gowerc requested a review from gravesti February 18, 2025 12:31
@github-actions GitHub Actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  --------------------------------
R/brier_score.R                      167       0  100.00%
R/DataJoint.R                         76       2  97.37%   264, 270
R/DataLongitudinal.R                 119       1  99.16%   244
R/DataSubject.R                       85       1  98.82%   142
R/DataSurvival.R                      98       0  100.00%
R/defaults.R                          10       6  40.00%   18-57, 84
R/generics.R                          33       4  87.88%   52, 382, 402, 457
R/Grid.R                              27       1  96.30%   173
R/GridEven.R                          32       0  100.00%
R/GridEvent.R                         22       0  100.00%
R/GridFixed.R                         30       0  100.00%
R/GridGrouped.R                       52       0  100.00%
R/GridManual.R                        23       3  86.96%   78-80
R/GridObserved.R                      20       0  100.00%
R/GridPopulation.R                    31       4  87.10%   61, 69-71
R/GridPrediction.R                    36       6  83.33%   83, 91-95
R/JointModel.R                       129      10  92.25%   148-153, 203, 207, 249, 295, 301
R/JointModelSamples.R                 66       0  100.00%
R/link_generics.R                     16       4  75.00%   59, 76, 91, 106
R/Link.R                              62       4  93.55%   200-203
R/LinkComponent.R                     19       3  84.21%   88, 120-121
R/LongitudinalClaretBruno.R           90       6  93.33%   168-172, 187
R/LongitudinalGSF.R                   95       0  100.00%
R/LongitudinalModel.R                 19       0  100.00%
R/LongitudinalQuantities.R            71       0  100.00%
R/LongitudinalRandomSlope.R           44       5  88.64%   102-106
R/LongitudinalSteinFojo.R             86       5  94.19%   159-163
R/Parameter.R                         14       0  100.00%
R/ParameterList.R                     42       1  97.62%   184
R/Prior.R                            270       6  97.78%   547, 691-705
R/Promise.R                           25       0  100.00%
R/Quantities.R                        60       0  100.00%
R/QuantityGeneratorPopulation.R       22       0  100.00%
R/QuantityGeneratorPrediction.R       48       0  100.00%
R/QuantityGeneratorSubject.R          19       0  100.00%
R/settings.R                          12      12  0.00%    55-69
R/SimGroup.R                           5       0  100.00%
R/SimJointData.R                      72       1  98.61%   103
R/SimLongitudinal.R                    5       2  60.00%   22, 40
R/SimLongitudinalClaretBruno.R        74       0  100.00%
R/SimLongitudinalGSF.R                80       0  100.00%
R/SimLongitudinalRandomSlope.R        42       0  100.00%
R/SimLongitudinalSteinFojo.R          69       0  100.00%
R/SimSurvival.R                      116       0  100.00%
R/StanModel.R                         15       0  100.00%
R/StanModule.R                       176       6  96.59%   192-193, 235, 246, 383, 411
R/SurvivalExponential.R               10       0  100.00%
R/SurvivalGamma.R                     13       0  100.00%
R/SurvivalLoglogistic.R               11       0  100.00%
R/SurvivalModel.R                     19       0  100.00%
R/SurvivalQuantities.R               170       1  99.41%   125
R/SurvivalWeibullPH.R                 13       0  100.00%
R/utilities.R                        144       2  98.61%   13, 335
R/zzz.R                               29      26  10.34%   4-8, 10-31, 38-47
TOTAL                               3133     122  96.11%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
R/Prior.R       +16       0  +0.14%
TOTAL           +16       0  +0.02%

Results for commit: 5ec8545

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

Unit Tests Summary

    1 files    179 suites   5m 38s ⏱️
  157 tests   145 ✅ 12 💤 0 ❌
1 098 runs  1 085 ✅ 13 💤 0 ❌

Results for commit 5ec8545.

@github-actions GitHub Actions
Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
JointModelSamples 💔 $8.26$ $+21.21$ $0$ $-1$ $0$ $0$
compile 💚 $10.41$ $-6.02$ $0$ $0$ $0$ $0$
extract_quantities 💚 $12.26$ $-11.45$ $0$ $0$ $0$ $0$
misc_models 💚 $11.63$ $-4.25$ $0$ $0$ $0$ $0$
model_multi_chain 💚 $52.22$ $-24.36$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
Grid 💚 $85.60$ $-41.07$ Grid_objects_work_with_QuantityGenerator_and_QuantityCollapser
GridPrediction 💔 $114.87$ $+2.05$ GridPrediction_works_as_expected_for_Survival_models
JointModelSamples 💔 $8.26$ $+21.21$ print_works_as_expected_for_JointModelSamples
LongitudinalClaretBruno 💚 $1770.08$ $-1763.91$ LongitudinalClaretBruno_works_as_expected_with_default_arguments
LongitudinalGSF 💚 $683.93$ $-676.84$ LongitudinalGSF_works_as_expected_with_default_arguments
LongitudinalQuantiles 💚 $39.08$ $-35.64$ Test_that_LongitudinalQuantities_works_as_expected
LongitudinalRandomSlope 💚 $67.58$ $-45.19$ Print_method_for_LongitudinalRandomSlope_works_as_expected
LongitudinalSteinFojo 💚 $1446.63$ $-1439.16$ LongitudinalSteinFojo_works_as_expected_with_default_arguments
SurvivalExponential 💚 $23.64$ $-21.40$ Can_load_and_compile_SurvivalExponential_model
SurvivalGamma 💚 $193.96$ $-192.56$ Print_method_for_SurvivalGamma_works_as_expected
SurvivalLoglogistic 💚 $40.06$ $-38.61$ Can_load_and_compile_SurvivalLogLogistic_model
SurvivalQuantities 💚 $78.73$ $-48.42$ SurvivalQuantities_and_autoplot.SurvivalQuantities_works_as_expected
SurvivalWeibullPH 💚 $14.69$ $-13.29$ Print_method_for_SurvivalWeibullPH_works_as_expected
brierScore 💚 $17.18$ $-14.72$ brierScore_SurvivalQuantities_returns_same_results_as_survreg
brms_compare 💚 $327.21$ $-327.13$ jmpost_and_brms_get_similar_loo_for_longitudinal_models
compile 💚 $10.41$ $-6.02$ compileStanModel_doesn_t_error_if_the_directory_doesn_t_exist
extract_quantities 💚 $12.26$ $-11.45$ extract_quantities_works_as_expected
misc_models 💚 $11.63$ $-4.25$ Longitudinal_Model_doesn_t_print_sampler_rejection_messages
model_multi_chain 💚 $52.22$ $-24.36$ Can_recover_known_distribution_parameters_from_random_slope_model_when_using_multiple_chains
stan_functions 💚 $38.12$ $-38.02$ GSF_SLD_function_works_as_expected

Results for commit 3408f23

♻️ This comment has been updated with latest results.

gravesti
gravesti approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @gowerc

@gowerc gowerc merged commit 016d639 into main Feb 18, 2025
20 checks passed
@gowerc gowerc deleted the 432-autoplot-examples branch February 18, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravesti gravesti gravesti approved these changes

Assignees

@gravesti gravesti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with "scales = 'free'" on longitudinal plots
2 participants
@gowerc @gravesti